Jump to content
  • Pool Tab Breaks When Double Quote In Title


    adam_
    • Status: Fixed Priority: High

    Hey all, another small bug in the new HTML5 client for you ...

    If a user has a double quote in the name of a pool ("), it fails to load the associated tab as it does on the Flash chat. See the difference below ...

    kuCBoBHZRsidweqM4lcmTA.png

    (Pool tabs working fine on Flash client)

     

    uCGN8vVUSZmzTPCMnP_GAQ.png

    (Two pool tabs failing to load on HTML5 client)

     

    Luckily the failure to load the tabs doesn't seem to be caused by the quotes breaking the HTML client (so no XSS vulnerability is present), instead, it is more than likely that there is some XSS-preventative code somewhere in the JS (I don't have the patience to validate that for such a small bug).

    It's obvious that all that needs to be done here is to remove double quotes from the pool names upon saving the chat settings.

     

    Again, a very small bug that doesn't impact anyone as such, but it can all be used to iron out bugs in the HTML5 chat as development progresses.

    This bug does have the funny effect of being able to 'lock' someone into a pool though, since if the double quote is in the main pool name, there's no way to return to it.

     

    Thanks


    Steps to reproduce bug: Step 1: 
    Step 2: 
    Step 3: 
    etc

    User Feedback

    Recommended Comments

    • Volunteers

    Confirmed bug.

     

    Thank you for report.

     

    If you find issues of this kind or if you have more information to add about, please report.

    Link to comment
    Share on other sites



    Guest
    This is now closed for further comments

  • Priority Definitions

     

    Trivial The issue is considered low priority.

    Normal This is the default priority.

    High A feature or service is not working properly, and it impacts a lot of people. The issue should be fixed in the near future.

    Critical The issue is show-stopping, meaning that a certain feature or service is completely broken with no available workaround. The issue impacts a lot of people and requires immediate repair.

  • Status Definitions

     

    Open The issue is pending, or we are still working on the issue.

    Fixed The issue has been resolved. The fix may not be immediately noticeable and may be released in a future version or update.

    Closed This record is either not considered an issue or is better suited as a suggestion. If it is an issue, it may not be reproducible.

    Won't Fix The issue will not be fixed because it is too low in priority. The issue is very minor. The resources required to fix the issue cannot justify the benefits received from fixing the issue. This means the issue is closed.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.